Add chainerx tests to test_checkpoint.py #8429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keisukefukuda
added
cat:test
belldandyxtq
requested changes
Nov 15, 2019
| checkpointer = create_multi_node_checkpointer(name='hoge', | ||
| comm=self.communicator, | ||
| cp_interval=23, | ||
| gc_interval=32) | ||
| nums = [np.random.randint(4096) for _ in range(234)] | ||
| nums = [int(xp.random.uniform() * 4096) for _ in range(234)] |
There was a problem hiding this comment.
is this caused by the same problem with https://github.com/chainer/chainer/pull/8346/files#r346664255
There was a problem hiding this comment.
No, it is just because chainerx doesn't have randint() so instead we have to use random.uniform(), which returns floating-point values.
belldandyxtq
approved these changes
Nov 29, 2019
|
pfnci, test this please |
|
Jenkins CI test (for commit 30cdb9f, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of #8031. It adds ChainerX tests to test_checkpoint.py