Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random in ChainerX n-step GRU test #8431

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Nov 13, 2019

Fixes #8274

0 failure in 10,000 runs (I feel a bit silly but checked anyway)

@kmaehashi kmaehashi added the cat:test Test or CI related. label Nov 14, 2019
@asi1024
Copy link
Member

asi1024 commented Nov 14, 2019

Jenkins, test this please.

@asi1024 asi1024 added this to the v7.0.0 milestone Nov 14, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 9b92f55, target branch master) succeeded!

@asi1024
Copy link
Member

asi1024 commented Nov 14, 2019

LGTM.

@asi1024 asi1024 merged commit 8761c78 into chainer:master Nov 14, 2019
@niboshi niboshi deleted the chainerx-nstep-gru-test-fix-random branch November 14, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: tests/chainerx_tests/unit_tests/routines_tests/test_rnn.py test_NStepGru
4 participants