Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chainerx tests into multi_node_optimizer #8436

Merged

Conversation

belldandyxtq
Copy link
Member

@belldandyxtq belldandyxtq commented Nov 13, 2019

This PR adds chainerx tests into multi_node_optimizer in chainermn.
This PR solves part of #8031.

The test class is changed to inherit from object instead of unitest.TestCase to support pytest.parametrize

@belldandyxtq belldandyxtq added cat:test Test or CI related. ChainerMN Related to ChainerMN. labels Nov 13, 2019
This commit adds chainerx tests into multi_node_optimizer in chainermn.
@belldandyxtq belldandyxtq changed the title [WIP] Add chainerx tests into multi_node_optimizer Add chainerx tests into multi_node_optimizer Nov 14, 2019
@keisukefukuda
Copy link
Member

pfnci, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 692f835, target branch master) succeeded!

@keisukefukuda keisukefukuda merged commit 26c7764 into chainer:master Dec 2, 2019
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. ChainerMN Related to ChainerMN.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants