Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unused function warning in NVCC #8439

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Nov 13, 2019

Ignore unused function warnings in NVCC that comes from CUDA system headers.
It's not possible to ignore warnings selectively in system headers because CMake's CUDA module doesn't support SYSTEM specification for include directories (https://gitlab.kitware.com/cmake/cmake/issues/16464), so relevant warnings from all the sources are ignored.

Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@take-cheeze take-cheeze added ChainerX Related to ChainerX. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Nov 14, 2019
@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 54c7bf4, target branch master) succeeded!

@mergify mergify bot merged commit 07cc7a2 into chainer:master Nov 14, 2019
@niboshi niboshi deleted the ignore-warning-nvcc branch November 14, 2019 09:27
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
@kmaehashi kmaehashi added the cat:install Build and installation. label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:install Build and installation. ChainerX Related to ChainerX. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants