Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several documentation errors in chainer.functions.rnn.* #8454

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Fix several documentation errors in chainer.functions.rnn.* #8454

merged 1 commit into from
Jan 6, 2020

Conversation

msakai
Copy link
Contributor

@msakai msakai commented Nov 18, 2019 •
edited
Loading

This PR contains two doc fixes:

  • fixing weight matrix sizes from (I, N) to (N, I), and
  • fixing bias/weight indexes in n_step_birnn from i + di to 2 * i + di.

@Crissman Crissman self-assigned this Nov 19, 2019
@msakai
Copy link
Contributor Author

msakai commented Dec 4, 2019

For the (I, N) to (N, I) changes, I made a jupyter notebook to confirm the actual behavior.

@msakai
Copy link
Contributor Author

msakai commented Dec 23, 2019

Friendly ping, @Crissman.

@takagi
Copy link
Member

takagi commented Dec 23, 2019

I take over reviewing this PR.

@takagi
Copy link
Member

takagi commented Dec 23, 2019

pfnCI, test this please.

@takagi takagi self-assigned this Dec 23, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 18dcfee, target branch master) failed with status FAILURE.

@takagi takagi added cat:document Documentation such as function documentations, comments and tutorials. st:blocked-by-another-pr State indicating that another ticket is preventing this ticket from being closed/merged. to-be-backported Pull request that should be backported. labels Dec 24, 2019
@takagi
Copy link
Member

takagi commented Jan 6, 2020

pfnCI, test this please.

@takagi takagi removed the st:blocked-by-another-pr State indicating that another ticket is preventing this ticket from being closed/merged. label Jan 6, 2020
@takagi
Copy link
Member

takagi commented Jan 6, 2020

CI failed because of the change in NumPy 1.18 and the problem is fixed in #8521. Now the CI should pass so I've kicked it again.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 18dcfee, target branch master) succeeded!

@takagi takagi added this to the v7.1.0 milestone Jan 6, 2020
@takagi
Copy link
Member

takagi commented Jan 6, 2020

LGTM!

@takagi takagi merged commit 9350aa3 into chainer:master Jan 6, 2020
@takagi takagi mentioned this pull request Jan 6, 2020
Merged
takagi added a commit to takagi/chainer that referenced this pull request Jan 6, 2020
@takagi
Merge pull request chainer#8454 from msakai/fix-rnn-doc
1257689 
Fix several documentation errors in chainer.functions.rnn.*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@takagi takagi

@Crissman Crissman

Labels
cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msakai @takagi @chainer-ci @Crissman