Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parametrize_device_name to setup.cfg #8459

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

emcastillo
Copy link
Member

This was preventing ChainerX from running with newer pytest versions

E   pytest.PytestUnknownMarkWarning: Unknown pytest.mark.parametrize_device_name - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/latest/mark.html

Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The cause is the conflict between #7988 and #8112.

@toslunar toslunar self-assigned this Nov 19, 2019
@toslunar toslunar added the cat:test Test or CI related. label Nov 19, 2019
@toslunar
Copy link
Member

Jenkins & flexCI, test this please.

@toslunar toslunar added this to the v7.0.0 milestone Nov 20, 2019
@toslunar toslunar added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 20, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 6a0e179, target branch master) succeeded!

@toslunar toslunar merged commit d473d3a into chainer:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants