Fix ONNX-Chainer's GetItem converter to handle -1 correctly
#8460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When -1 is given as a slice, current implementation wrongly treat it as slice(-1, 0) which select no elements at all. We avoid the problem by treating it as slice(-1, np.iinfo(np.int64).max) because ONNX's Operator Schemas recommends to pass in INT_MAX for slicing to the end of a dimension with unknown size.
|
Jenkins, test this please! |
|
Jenkins CI test (for commit 899381b, target branch master) succeeded! |
|
The travis fail is unrelated to this PR, so merge this manually. (The error has already resolved by another PR). |
emcastillo
changed the title
GetItem converter to handle -1 correctly
emcastillo
changed the title
GetItem converter to handle -1 correctlyGetItem converter to handle -1 correctly
|
Jenkins CI test (for commit 899381b, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
-1is given as a slice, current implementation wrongly treat it asslice(-1, 0)which select no elements at all.This PR avoid the problem by treating it as
slice(-1, np.iinfo(np.int64).max)because ONNX's Operator Schemas recommends to pass inINT_MAXfor slicing to the end of a dimension with unknown size.