Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chainerx.batch_norm with 2D input on CUDA #8464

Merged
merged 4 commits into from
Nov 21, 2019

Conversation

emcastillo
Copy link
Member

Takeover #8302

Error only happened on the Debug version of ChainerX because of an assert that was doing a CUDNN call with an invalid shape.

Copy link
Member

@niboshi niboshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niboshi niboshi added cat:bug Bug report or fix. cat:enhancement Implementation that does not break interfaces. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. and removed cat:bug Bug report or fix. labels Nov 21, 2019
@niboshi niboshi self-assigned this Nov 21, 2019
@niboshi niboshi added this to the v7.0.0 milestone Nov 21, 2019
@niboshi niboshi added cat:bug Bug report or fix. to-be-backported Pull request that should be backported. and removed cat:enhancement Implementation that does not break interfaces. to-be-backported Pull request that should be backported. labels Nov 21, 2019
@niboshi
Copy link
Member

niboshi commented Nov 21, 2019

Jenkins, test this please

@niboshi niboshi changed the title [Takeover] Support chainerx.batch_norm with 2D input on CUDA Support chainerx.batch_norm with 2D input on CUDA Nov 21, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit d190e92, target branch master) succeeded!

@mergify mergify bot merged commit 7c4c79c into chainer:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:bug Bug report or fix. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants