Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectItem using GatherElements for ONNX opset>=11 #8470

Merged
merged 1 commit into from
Nov 21, 2019
Merged

SelectItem using GatherElements for ONNX opset>=11 #8470

merged 1 commit into from
Nov 21, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Nov 21, 2019

GatherElements is more intuitive for F.select_item converter, but remain current logic for some runtimes which not support GatherElements operator.

ref: #8450 (comment)

@disktnk disktnk added the ONNX Related to ONNX label Nov 21, 2019
@disktnk disktnk changed the title SelectItem using GatherElements for ONNX opset>11 SelectItem using GatherElements for ONNX opset>=11 Nov 21, 2019
@take-cheeze
Copy link
Member

Jenkins, test this please!

@take-cheeze take-cheeze self-assigned this Nov 21, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 862c952, target branch master) succeeded!

@take-cheeze take-cheeze added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 21, 2019
take-cheeze
take-cheeze approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify bot merged commit 421d203 into chainer:master Nov 21, 2019
@disktnk disktnk deleted the fix/gather-elements branch November 21, 2019 15:12
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
@kmaehashi kmaehashi added the cat:enhancement Implementation that does not break interfaces. label Dec 5, 2019
@emcastillo emcastillo changed the title SelectItem using GatherElements for ONNX opset>=11 SelectItem using GatherElements for ONNX opset>=11 Dec 5, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 862c952, target branch master) succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@take-cheeze take-cheeze take-cheeze approved these changes

Assignees

@take-cheeze take-cheeze

Labels
cat:enhancement Implementation that does not break interfaces. ONNX Related to ONNX st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@disktnk @take-cheeze @chainer-ci @kmaehashi