Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround for cuSolver 10.2's new enums #8475

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Add workaround for cuSolver 10.2's new enums #8475

merged 1 commit into from
Nov 26, 2019

Conversation

take-cheeze
Copy link
Member

Seems CUSOLVER_STATUS_IRS_* is added but can't be handled in current code

@take-cheeze take-cheeze added the ChainerX Related to ChainerX. label Nov 22, 2019
@niboshi
Copy link
Member

niboshi commented Nov 25, 2019

How about using #if and CUSOLVER_VERSION to use new enum members?

@niboshi niboshi self-assigned this Nov 25, 2019
@niboshi niboshi added the st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. label Nov 26, 2019
@take-cheeze
Copy link
Member Author

@niboshi I think it should be added when cusolverDnIRS* functions get supported.

@niboshi
Copy link
Member

niboshi commented Nov 26, 2019

I don't really think we should, but this fix itself is OK.

@niboshi
Copy link
Member

niboshi commented Nov 26, 2019

Jenkins, test this please

@niboshi niboshi added st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. cat:enhancement Implementation that does not break interfaces. and removed st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. labels Nov 26, 2019
@niboshi niboshi added this to the v7.0.0 milestone Nov 26, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4e74b7a, target branch master) succeeded!

@mergify mergify bot merged commit 76680a3 into chainer:master Nov 26, 2019
@take-cheeze take-cheeze deleted the chx_cusolver_10_2 branch November 26, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
cat:enhancement Implementation that does not break interfaces. ChainerX Related to ChainerX. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@take-cheeze @niboshi @chainer-ci