Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test of _modified_xlogx #8483

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Fix flaky test of _modified_xlogx #8483

merged 1 commit into from
Nov 28, 2019

Conversation

toslunar
Copy link
Member

Fix #8390.

@toslunar toslunar added the cat:test Test or CI related. label Nov 28, 2019
@niboshi niboshi self-assigned this Nov 28, 2019
@niboshi
Copy link
Member

niboshi commented Nov 28, 2019

Thank you for the fix.
LGTM, but could you post the failure rate if you have measured?

@niboshi niboshi added the to-be-backported Pull request that should be backported. label Nov 28, 2019
@niboshi niboshi added this to the v7.0.0 milestone Nov 28, 2019
@toslunar
Copy link
Member Author

Not yet.

@niboshi
Copy link
Member

niboshi commented Nov 28, 2019

OK

@niboshi
Copy link
Member

niboshi commented Nov 28, 2019

No failure in 100,000 runs.

@niboshi
Copy link
Member

niboshi commented Nov 28, 2019

Jenkins, test this please

@niboshi niboshi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 28, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit a25a516, target branch master) failed with status FAILURE.

@niboshi
Copy link
Member

niboshi commented Nov 28, 2019

Test failure is unrelated.

@niboshi niboshi merged commit 1386c20 into chainer:master Nov 28, 2019
@niboshi niboshi mentioned this pull request Nov 28, 2019
Merged
niboshi added a commit to niboshi/chainer that referenced this pull request Nov 28, 2019
@niboshi
Merge pull request chainer#8483 from toslunar/flaky-test-xlogx
0355803 
Fix flaky test of `_modified_xlogx`
@toslunar toslunar deleted the flaky-test-xlogx branch November 29, 2019 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

Flaky test: chainer_tests/distributions_tests/test_utils.py::ModifiedXLogX
3 participants
@toslunar @niboshi @chainer-ci