Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ONNX-Chainer's TransposeSequence converter to support more cases #8493

Merged

Conversation

msakai
Copy link
Contributor

@msakai msakai commented Dec 3, 2019

In addition to the case where the input or output is length 1, this PR newly adds support for cases where all inputs have the same shape.

In addition to the case where the input or output is length 1, it
newly supports cases where all inputs have the same shape.
@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit b1a9f55, target branch master) failed with status FAILURE.

@disktnk disktnk self-requested a review December 17, 2019 07:45
Copy link
Member

@disktnk disktnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@take-cheeze
Copy link
Member

Jenkins failure seems to be unrelated

@take-cheeze take-cheeze merged commit 9c83c8d into chainer:master Dec 17, 2019
@kmaehashi kmaehashi added this to the v7.1.0 milestone Jan 16, 2020
@kmaehashi kmaehashi added the cat:enhancement Implementation that does not break interfaces. label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces. ONNX Related to ONNX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants