Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BatchNormalization for NHWC without cudnn #8497

Merged
merged 3 commits into from
Dec 4, 2019

Conversation

emcastillo
Copy link
Member

Miss configuration in the tests made nhwc batchnorm test to use always cudnn.
There was a bug when using NHWC without cudnn due to doing reductions in the incorrect axes.

@niboshi
Copy link
Member

niboshi commented Dec 4, 2019

Please remove test skips for CPU backends.

@emcastillo
Copy link
Member Author

Ideep segfaults with NHWC, I am not sure if we should add a warning.

@niboshi
Copy link
Member

niboshi commented Dec 4, 2019

Jenkins, test this please

@niboshi niboshi added cat:bug Bug report or fix. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Dec 4, 2019
@niboshi niboshi self-assigned this Dec 4, 2019
@niboshi niboshi added this to the v7.0.0 milestone Dec 4, 2019
@niboshi
Copy link
Member

niboshi commented Dec 4, 2019

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 9b59a70, target branch master) succeeded!

@kmaehashi
Copy link
Member

/test

@mergify mergify bot merged commit df71486 into chainer:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:bug Bug report or fix. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants