Raise RuntimeError when using cudnn_fast without cudnn
#8499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
reviewed
Dec 4, 2019
emcastillo
force-pushed
the
fix_nhwc_conv
branch
from
7d39ab3
to
5d82628
Compare
niboshi
requested changes
Dec 4, 2019
tests/chainer_tests/links_tests/connection_tests/test_convolution_2d.py
Outdated
Show resolved
Hide resolved
|
Extracted them to another class |
niboshi
requested changes
Dec 4, 2019
tests/chainer_tests/links_tests/connection_tests/test_convolution_2d.py
Outdated
Show resolved
Hide resolved
tests/chainer_tests/links_tests/connection_tests/test_convolution_2d.py
Outdated
Show resolved
Hide resolved
tests/chainer_tests/links_tests/connection_tests/test_convolution_2d.py
Outdated
Show resolved
Hide resolved
emcastillo
force-pushed
the
fix_nhwc_conv
branch
2 times, most recently
from
a5b1bc6
to
ff4b410
Compare
emcastillo
force-pushed
the
fix_nhwc_conv
branch
from
ff4b410
to
ff02372
Compare
|
PTAL |
|
Thanks |
niboshi
added
cat:enhancement
niboshi
approved these changes
Dec 4, 2019
|
Jenkins CI test (for commit ff02372, target branch master) succeeded! |
niboshi
removed
the
st:test-and-merge
|
pfnCI, test this please. |
|
Jenkins CI test (for commit e224c04, target branch master) succeeded! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convolution2d should not use
cudnn_fastcompute mode if cudnn is not enabled.The changes required for this involve modifying
im2colandcol2imto support NHWC layoutThe compute mode can only be checked at the link creation time but the associated function checks
use_cudnnat forward time. Ideally we should check this at creation time in the link, but since chainer allows to dynamically change some of the backend properties based on the input I deferred the check to the functionforward.