Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '--pre' from 'pip install' commands in ChainerX installation document #8527

Merged

Conversation

msakai
Copy link
Contributor

@msakai msakai commented Dec 31, 2019

Since ChainerX is already included in released version of Chainer, I believe that it is no longer necessary to specify --pre.

…ocument

Since ChainerX is already included in released version of Chainer,
it is no longer necessary to specify '--pre'.
@asi1024 asi1024 self-assigned this Jan 6, 2020
@asi1024 asi1024 added the cat:document Documentation such as function documentations, comments and tutorials. label Jan 6, 2020
@asi1024
Copy link
Member

asi1024 commented Jan 6, 2020

Thanks for your PR! Jenkins, test this please.

@asi1024 asi1024 added this to the v7.1.0 milestone Jan 6, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit c1a5031, target branch master) succeeded!

@asi1024
Copy link
Member

asi1024 commented Jan 6, 2020

LGTM.

@asi1024 asi1024 merged commit 1047677 into chainer:master Jan 6, 2020
@asi1024 asi1024 added the to-be-backported Pull request that should be backported. label Jan 6, 2020
asi1024 added a commit to asi1024/chainer that referenced this pull request Jan 6, 2020
…installation-doc

Remove '--pre' from 'pip install' commands in ChainerX installation document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants