Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespaces #8536

Merged
merged 1 commit into from Jan 14, 2020
Merged

Conversation

himkt
Copy link
Contributor

@himkt himkt commented Jan 14, 2020

Close #8179

This PR removes trailing spaces in messages in messages and content to be generated (edited after looking #8536 (comment)).
I reproduced the file list in #8179 by running the command git grep ' \\\n'

(I also checked by git grep -E "\s$" chainer/**/*.py chainerx/**/*.py examples/**/*.py onnx_chainer/**/*.py tests/**/*.py to find nothing)

@toslunar toslunar self-assigned this Jan 14, 2020
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -383,7 +383,7 @@ def __call__(self, name, inputs, outputs):
for i in inputs[0].shape:
f.write(' dim: ' + str(i))
f.write(' } }\n'
'} \n')
'}\n')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
Good to fix the line, too, while it is a part of protobuf txt (the description in #8179 was not exact).

@toslunar
Copy link
Member

Jenkins, test this please.

@toslunar toslunar added cat:enhancement Implementation that does not break interfaces. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Jan 14, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 1005b41, target branch master) succeeded!

@mergify mergify bot merged commit c798507 into chainer:master Jan 14, 2020
@toslunar toslunar added this to the v7.1.0 milestone Jan 14, 2020
@himkt himkt deleted the trailing-whitespace branch January 14, 2020 09:44
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 1005b41, target branch master) succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing spaces in messages
3 participants