Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update functions.rst #8557

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Update functions.rst #8557

merged 1 commit into from
Apr 16, 2020

Conversation

husisy
Copy link
Contributor

@husisy husisy commented Apr 15, 2020

For New-Style functions, one should use ".apply()" method instead of "call()".
I follow the documentation to run the origin code but fail with a RuntimeError. After changing to ".apply()", the code will pass.
(my second time to make a pull request, please tell if anything unsuitable. sincerely)

Thank you for creating a pull request!

Please double-check the following.

For New-Style functions, one should use ".apply()" method instead of "__call__()".
@kmaehashi kmaehashi self-assigned this Apr 16, 2020
@kmaehashi kmaehashi added the cat:document Documentation such as function documentations, comments and tutorials. label Apr 16, 2020
@kmaehashi
Copy link
Member

Thanks, LGTM!

@kmaehashi
Copy link
Member

pfnCI, test this please.

@kmaehashi kmaehashi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Apr 16, 2020
@kmaehashi kmaehashi added this to the v7.3.0 milestone Apr 16, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 0ae73d0, target branch master) succeeded!

@mergify mergify bot merged commit a0fc29c into chainer:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation such as function documentations, comments and tutorials. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants