Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis macOS failure #8562

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

toslunar
Copy link
Member

@toslunar toslunar commented May 20, 2020

This PR partially fixes Travis macOS failure on the master branch by using a newer Python 3.5.x.

@toslunar
Copy link
Member Author

The remaining error is around #8393 (comment). Let's leave it now.

@emcastillo emcastillo self-assigned this May 21, 2020
.travis.yml Outdated
- PYENV_ROOT=~/.pyenv
- PATH=$PYENV_ROOT/shims:$PATH:$PYENV_ROOT/bin
- GOROOT=/usr/local/opt/go/libexec
if: (branch = master OR branch = v6) AND (NOT type in (pull_request))
# if: (branch = master OR branch = v6) AND (NOT type in (pull_request))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line will be restored after the PR is reviewed.

Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM,

Ths sphinx error should be fixed in a different PR or in this one?

@toslunar toslunar changed the title [DO NOT MERGE] Fix Travis macOS failure Fix Travis macOS failure May 25, 2020
@toslunar
Copy link
Member Author

For record, the result before the force-push was https://travis-ci.org/github/chainer/chainer/jobs/689182346

@toslunar toslunar marked this pull request as ready for review May 25, 2020 02:57
@toslunar toslunar added the cat:test Test or CI related. label May 25, 2020
@toslunar
Copy link
Member Author

Ths sphinx error should be fixed in a different PR or in this one?

In a different PR.

@emcastillo
Copy link
Member

Jenkins, test this please

@emcastillo emcastillo added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label May 26, 2020
@emcastillo emcastillo added this to the v7.6.0 milestone May 26, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 53fbd19, target branch master) succeeded!

@emcastillo
Copy link
Member

Errors are not related

@emcastillo emcastillo merged commit 43c59d0 into chainer:master May 26, 2020
@toslunar toslunar deleted the fix-travis-macos branch May 29, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants