This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Add crop_bbox #291
Merged
Add crop_bbox #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyu2172
reviewed
Jun 22, 2017
| tensor of shape :math:`(R, 4)`, where :math:`R` is the number of | ||
| bounding boxes in the image. The second axis represents attributes of | ||
| the bounding box. They are :obj:`(y_min, x_min, y_max, x_max)`, | ||
| where the four attributes are coordinates of the bottom left and the |
There was a problem hiding this comment.
Thank you for pointing out. #294
| y_slice (slice): The slice of y axis. | ||
| x_slice (slice): The slice of x axis. | ||
| allow_outside_center (bool): If this argument is :obj:`False`, | ||
| bounding boxes whose centers are outside of the cropping area |
| This method is mainly used together with image cropping. | ||
| This method translates the coordinates of bounding boxes like | ||
| :func:`~chainercv.transforms.translate_bbox`. In addition, | ||
| this function truncates the bounding boxes to fit within the cropping area. |
| This method translates the coordinates of bounding boxes like | ||
| :func:`~chainercv.transforms.translate_bbox`. In addition, | ||
| this function truncates the bounding boxes to fit within the cropping area. | ||
| If a bounding box does not overlap with the cropping area, |
| def crop_bbox( | ||
| bbox, y_slice=None, x_slice=None, | ||
| allow_outside_center=True, return_param=False): | ||
| """Crop bounding boxes. |
There was a problem hiding this comment.
This is confusing because it sound as if bounding boxes are cropped into a smaller piece.
How about "Translate bounding boxes to a cropped region of an image."
There was a problem hiding this comment.
This function crops bounding boxes into a smaller piece.
There was a problem hiding this comment.
Yeah, but main purpose of this function is not to crop bounding boxes into smaller pieces.
Its main purpose is to adjust bounding boxes to reflect image cropping.
I think this should be clear in the beginning of the doc.
|
LGTM |
yuyu2172
approved these changes
Jun 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.