This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Support (C, 1, 1) for fill argument #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyu2172
reviewed
Jun 30, 2017
| @@ -24,6 +24,9 @@ def random_expand(img, max_ratio=4, fill=0, return_param=False): | |||
| paper, this value is 4. | |||
| fill (float, tuple or ~numpy.ndarray): The value of padded pixels. | |||
There was a problem hiding this comment.
I think supporting tuple is convenient. Why do you want to drop it?
There was a problem hiding this comment.
Let me summarize.
fill can be one of float, tuple or (C, 1, 1).
mean is (C, 1, 1).
There was a problem hiding this comment.
fill can be one of float, tuple or (C, 1, 1).
mean is (C, 1, 1).
Yes. And I want to pass a tuple value that is never broadcasted to an image.
yuyu2172
reviewed
Jun 30, 2017
| @@ -19,6 +19,9 @@ def resize_contain(img, size, fill=0, return_param=False): | |||
| size (tuple of two ints): A tuple of two elements: | |||
| :obj:`height, width`. The size of the image after resizing. | |||
| fill (float, tuple or ~numpy.ndarray): The value of padded pixels. | |||
|
LGTM |
yuyu2172
approved these changes
Jul 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.