Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Import cupy as cp #316

Merged
merged 2 commits into from
Jul 5, 2017
Merged

Import cupy as cp #316

merged 2 commits into from
Jul 5, 2017

Conversation

yuyu2172
Copy link
Member

@yuyu2172 yuyu2172 commented Jul 5, 2017

No description provided.

@yuyu2172 yuyu2172 changed the title Abbreviate cupy by cp Import cupy as cp Jul 5, 2017
@yuyu2172 yuyu2172 requested a review from Hakuyume July 5, 2017 01:45
@@ -38,7 +38,7 @@ def non_maximum_suppression(bbox, thresh, score=None,
:obj:`score` is a float array of shape :math:`(R,)`. Each score indicates
confidence of prediction.

This function accepts both :obj:`numpy.ndarray` and :obj:`cupy.ndarray` as
This function accepts both :obj:`numpy.ndarray` and :obj:`cp.ndarray` as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For docs, cupy is better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry.


n_bbox = bbox.shape[0]

if score is not None:
# CuPy does not currently support argsort.
# cp does not currently support argsort.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cupy or CuPy

@yuyu2172 yuyu2172 added this to the v0.6 milestone Jul 5, 2017
Copy link
Member

@Hakuyume Hakuyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hakuyume Hakuyume merged commit 405b54f into chainer:master Jul 5, 2017
@yuyu2172 yuyu2172 deleted the cupy-cp branch July 5, 2017 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants