Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Add random_size_crop #432

Merged
merged 15 commits into from
Apr 11, 2018
Merged

Add random_size_crop #432

merged 15 commits into from
Apr 11, 2018

Conversation

yuyu2172
Copy link
Member

This transform is necessary to implement Facebook style resnet training.

@yuyu2172 yuyu2172 added this to the v0.8 milestone Sep 28, 2017
@yuyu2172 yuyu2172 force-pushed the random-sized-crop branch 4 times, most recently from 6bbd019 to a37b0b9 Compare September 28, 2017 07:36
@yuyu2172
Copy link
Member Author

Parameters are sampled multiple times in a loop because scale_ratio should not be sampled conditioned on the value of aspect_ratio.

@yuyu2172 yuyu2172 mentioned this pull request Sep 29, 2017
6 tasks

Args:
img (~numpy.ndarray): An image array. This is in CHW format.
scale_ratio_interval (tuple of two floats): Determines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer scale_ratio_range. interval is a difference between two values. In the case that the range is (0.08, 1), interval sounds 0.92 (1 - 0.08).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@yuyu2172 yuyu2172 modified the milestones: v0.8, v0.9 Dec 19, 2017
@akitotakeki akitotakeki mentioned this pull request Apr 8, 2018
Copy link
Member

@Hakuyume Hakuyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hakuyume Hakuyume merged commit cc9e153 into chainer:master Apr 11, 2018
@yuyu2172 yuyu2172 deleted the random-sized-crop branch April 11, 2018 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants