Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Chainer 3.0.0 #445

Merged
merged 19 commits into from
Nov 28, 2017
Merged

Chainer 3.0.0 #445

merged 19 commits into from
Nov 28, 2017

Conversation

Hakuyume
Copy link
Member

@Hakuyume Hakuyume commented Oct 6, 2017

@Hakuyume Hakuyume changed the title [WIP] Chainer 3.0.0 Chainer 3.0.0 Oct 17, 2017
@yuyu2172
Copy link
Member

yuyu2172 commented Nov 3, 2017

SegNet test fails due to Chainer 3.0.0 change.
#487

@Hakuyume
Copy link
Member Author

Hakuyume commented Nov 4, 2017

@yuyu2172 Thank you. I fixed it. Currently, Travis CI does not run any tests of SegNet because they are marked as slow.

@Hakuyume
Copy link
Member Author

@yuyu2172

README.md Outdated
@@ -43,8 +43,9 @@ For additional features

Environments under Python 2.7.12 and 3.6.0 are tested.

+ The master branch will work on both the stable version (v2) and the development version (v3).
+ The master branch will work on both the stable version (v3) and the development version (v4).
+ For users using Chainer v1, please use version `0.4.11`, which can be installed by `pip install chainercv==0.4.11`. This branch is unmaintained.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about not repeating the sentence "This branch is unmaintained".

@yuyu2172
Copy link
Member

Sorry for being late!

@yuyu2172
Copy link
Member

Should we add attributes for all methods or just one for each class?
I prefer declaring attr.slow for a class if all tests are slow because there are less code.

@Hakuyume
Copy link
Member Author

Should we add attributes for all methods or just one for each class?
I prefer declaring attr.slow for a class if all tests are slow because there are less code.

I also prefer declaring attr.slow for a class. However, it does not work since Chainer v3.1. I guess this is related to migration to PyTest.

@yuyu2172
Copy link
Member

I see.
This would force us to change other tests too.

@Hakuyume
Copy link
Member Author

Yes. I changed other tests, too.

@yuyu2172
Copy link
Member

LGTM

@yuyu2172 yuyu2172 merged commit 608cca8 into chainer:master Nov 28, 2017
@yuyu2172 yuyu2172 mentioned this pull request Dec 7, 2017
@Hakuyume Hakuyume deleted the chainer-3.0.0 branch December 15, 2017 07:16
@Hakuyume Hakuyume mentioned this pull request Dec 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants