Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Add COCOBboxDataset #453

Merged
merged 39 commits into from
Jun 5, 2018
Merged

Add COCOBboxDataset #453

merged 39 commits into from
Jun 5, 2018

Conversation

yuyu2172
Copy link
Member

Depends on #452

I think we need some modification to the BboxDataset API.

  1. bbox can be zero-sized (0,4).
  2. Make it easier to filter images with no ground truth bounding boxes. I suggest to make a public method labels for all bbox datasets. The method returns a list of bounding boxes. Also, I suggest to support similar method for all label datasets.

@Hakuyume
Copy link
Member

Make it easier to filter images with no ground truth bounding boxes. I suggest to make a public method labels for all bbox datasets. The method returns a list of bounding boxes. Also, I suggest to support similar method for all label datasets.

I guess the advantage of labels is that users can filter images without loading them. Is ii right?

@yuyu2172
Copy link
Member Author

Yea

@Hakuyume Hakuyume mentioned this pull request Oct 14, 2017
@Hakuyume
Copy link
Member

I made a mix-in for this problem. Please check #454.

@yuyu2172
Copy link
Member Author

yuyu2172 commented Oct 14, 2017

Areas of instance masks are needed for evaluation. So, I added an option that makes the dataset to return them.

I've been working on evaluation of COCO as well. My work can be found here.
https://github.com/yuyu2172/coco-evaluation/tree/master/detection

@Hakuyume Hakuyume added this to In progress in ChainerCV May 18, 2018
@Hakuyume Hakuyume moved this from In progress to Stall in ChainerCV May 18, 2018
@Hakuyume Hakuyume moved this from Stall to Ready to review in ChainerCV May 18, 2018
@yuyu2172
Copy link
Member Author

yuyu2172 commented Jun 5, 2018

@Hakuyume

@Hakuyume
Copy link
Member

Hakuyume commented Jun 5, 2018

@yuyu2172 Could you merge master branch?

@yuyu2172
Copy link
Member Author

yuyu2172 commented Jun 5, 2018

ok


There are total of 82,783 training and 40,504 validation images.
'minval' split is a subset of validation images that constitutes
5000 images in the validation images. The remaining validation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5,000 images?

@@ -51,6 +51,13 @@ CityscapesTestImageDataset
~~~~~~~~~~~~~~~~~~~~~~~~~~
.. autoclass:: CityscapesTestImageDataset

COCO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer MS COCO because we use PASCAL VOC in this doc.

Copy link
Member

@Hakuyume Hakuyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hakuyume Hakuyume merged commit dcbfcbb into chainer:master Jun 5, 2018
@Hakuyume Hakuyume removed this from Ready to review in ChainerCV Jun 5, 2018
@yuyu2172 yuyu2172 deleted the coco_detection branch June 5, 2018 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants