Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Improve appearence of y_offset and x_offset in doc #475

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Improve appearence of y_offset and x_offset in doc #475

merged 1 commit into from
Nov 29, 2017

Conversation

yuyu2172
Copy link
Member

Before

transforms_ _chainercv_0_7_0_documentation

After

transforms_ _chainercv_0_7_0_documentation

@yuyu2172 yuyu2172 added this to the v0.8 milestone Oct 27, 2017
@Hakuyume
Copy link
Member

It looks inconsistent with y_min, x_min, y_max, x_max. Is it OK?

@yuyu2172
Copy link
Member Author

yuyu2172 commented Oct 27, 2017 •
edited

I generally prefer math expression over code block for readability (there are some exceptions).
How about changing y_min, x_min, y_max, x_max to math expressions instead?

@Hakuyume
Copy link
Member

How about changing y_min, x_min, y_max, x_max to math expressions instead?

It is OK.

@yuyu2172 yuyu2172 mentioned this pull request Oct 28, 2017
Merged
Hakuyume
Hakuyume approved these changes Nov 29, 2017
View reviewed changes
Copy link
Member

@Hakuyume Hakuyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hakuyume Hakuyume merged commit e76edba into chainer:master Nov 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hakuyume Hakuyume Hakuyume approved these changes

Assignees

@Hakuyume Hakuyume

Labels
document enhancement
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuyu2172 @Hakuyume