Add COCO Instance segmentation dataset #665
Conversation
knorth55
changed the title
|
ready for review |
|
|
||
| try: | ||
| from pycocotools import mask as coco_mask | ||
| _availabel = True |
|
|
||
| self.add_getter('img', self._get_image) | ||
| self.add_getter(['mask', 'label', 'area', 'crowded'], | ||
| self._get_annotations) |
There was a problem hiding this comment.
If we can retrieve 'label', 'area', 'crowded' without loading 'mask', it is better to separate getter function.
There was a problem hiding this comment.
Can you tell me why?
self.use_crowded is set as True, crowded is loaded for every annotation.
There was a problem hiding this comment.
I mean making get_mask and get_label_area_crowded.
There was a problem hiding this comment.
I know mask requires crowded in some cases. However, label or area can be retrieved without loading mask.
There was a problem hiding this comment.
So, in _get_mask, crowded is loaded, but not returned?
There was a problem hiding this comment.
@Hakuyume can you give me more advice? spliting into two function is efficient for data load?
There was a problem hiding this comment.
He is saying that if _get_annotation is split into two, we can access labels without loading masks using dataset.slice[:, 'slice'].
We are assuming that loading masks takes substantially longer time than loading labels.
There was a problem hiding this comment.
So, in _get_mask, crowded is loaded, but not returned?
Yes, if use_crowded=False, _get_mask calls _get_label_area_crowded internally to get crowded. The crowded will be thrown away after filtering mask. If use_crowded=True, _get_mask doesn't need to call _get_label_area_crowded.
knorth55
force-pushed
the
coco-instance-segmentation-dataset
branch
from
8c83a8e
to
85b92f0
Compare
knorth55
force-pushed
the
coco-instance-segmentation-dataset
branch
from
85b92f0
to
b77ffba
Compare
Move from #547