Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

assert flip image ndim == 3 #688

Merged
merged 1 commit into from
Sep 18, 2018
Merged

assert flip image ndim == 3 #688

merged 1 commit into from
Sep 18, 2018

Conversation

knorth55
Copy link
Contributor

@knorth55 knorth55 commented Sep 8, 2018

No description provided.

@knorth55 knorth55 added this to the 0.11 milestone Sep 8, 2018
@knorth55 knorth55 mentioned this pull request Sep 8, 2018
Closed
@yuyu2172
Copy link
Member

Why do we need to add assertion for this function only?

@knorth55
Copy link
Contributor Author

knorth55 commented Sep 13, 2018 •
edited

because flip process like img[:, ::-1, :] can be done with imgs: (B, C, H, W) ndim == 4.
The other transform function should also check input shape and type, but it is other problems.

@yuyu2172
Copy link
Member

OK

@yuyu2172 yuyu2172 merged commit 992988b into chainer:master Sep 18, 2018
@knorth55 knorth55 deleted the assert-flip branch September 18, 2018 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuyu2172 yuyu2172 yuyu2172 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knorth55 @yuyu2172