Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Set names of output Variables from PickableSequentialChain #815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ktns
Copy link
Contributor

@ktns ktns commented Feb 25, 2019

Set names of output Variables from PickableSequentialChain, so that they match with names in pick and layer_names.

This is for more readable computational graphs.

@yuyu2172
Copy link
Member

There is a possibility that a user of PickableSequentialChain uses a function that outputs a variable with name...

@knorth55 knorth55 added this to the 0.13 milestone Feb 25, 2019
@yuyu2172
Copy link
Member

How about setting the name only when var.name is None?

@ktns
Copy link
Contributor Author

ktns commented Mar 3, 2019

If an instance of PicakbleSequentialChain has a nested PickableSequentialChain as its child, I think its better var.name is rewritten by the parent because the parent tends to have more information about the whole structure of the NN. I thought a scheme like parent_name/child_name is too complicated, but it might require reconsideration.

@yuyu2172 yuyu2172 modified the milestones: 0.13, 1.0 May 21, 2019
@yuyu2172 yuyu2172 added the stall label May 21, 2019
@knorth55 knorth55 removed this from the 1.0 milestone Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants