-
Notifications
You must be signed in to change notification settings - Fork 306
Conversation
From which version can we use |
@knorth55 V5. Here is the reference: https://docs.chainer.org/en/stable/upgrade.html?highlight=upgrade#use-forward-instead-of-call-in-links. |
pfnCI, test this please |
Successfully created a job for commit f7b1368: |
Please fix these errors.
|
I apologize to have missed chainercv/experimental/links and I'm working on them. |
can you also modify |
Sorry. I had not checked this seriously. |
pfnCI, test this please |
Successfully created a job for commit 45624ca: |
How do you think of the following items that contain chainercv/chainercv/utils/testing/constant_stub_link.py Lines 14 to 15 in 45624ca
https://github.com/chainer/chainercv/blame/45624ca3badfb3d530a9726375fa4ff9df7c5ced/examples/faster_rcnn/README.md#L16 |
I didn't change them because However, I noticed that other So, let me change them too. |
|
Do you think it's better to remove all `__call__`?
2019年3月22日(金) 13:26 Toru Ogawa <notifications@github.com>:
… *.rst files still contain __call__.
https://github.com/chainer/chainercv/blame/7af64e81012759314f7cff467bc19b350b7bcab7/docs/source/reference/links/faster_rcnn.rst#L26
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#835 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APcP051MJ7rYosDtXfH2AqxVBCdvkxPAks5vZFtwgaJpZM4b4Jdy>
.
|
Since |
LGTM |
No description provided.