Move from nose to pytest #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
memo: chainer/chainer#3952 is the key difference between Chainer 3.2 and 4.0 on 2534888 test failure. |
- Chainer has moved to pytest since 3.0.0 and now MN follows. An
example of testing tool mismatch is: Chainer's parameterized test
started checking all Exceptions including nose SkipTest(), at #3963
and #3876 which are included in 3.2.0 and 4.0, and all unit tests
that skips is recognized as test failure. Additionally, this patch
starts supporting Chainer 3.2.0 and 2.1.0, dropping 1.x as well (One
more issue to support 4.0 remains).
- Also, mixture of chainer.testing.attr.gpu and
chainer.testing.parametrize, with passing pytest to `-m 'not gpu'
does not work in pytest because nose's attributes are direct
attribute to test object or function, in contrast to pytest. Thus
this patch dissolves all parametrized tests that is using `{gpu:
True}, {gpu: False}` or `{nccl: True}, {nccl: False}` as parameters,
which is replaced by simple function call patters with
`@pytest.mark.gpu` and `@pytest.mark.nccl`.
- Add Python 3.6 as test target in Travis.
- Fix test_scatter_large_dataset not working for flat communicator
|
I think its ready for review. And quote from last commit:
|
Closed
|
CI test failures are all against Chainer 2.1 and this is because it's |
|
As it turned out we don't need any |
|
Superseded by #167 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chainer has moved to pytest since 3.0.0 and now MN follows.
An example of testing tool mismatch is: Chainer's parameterized test
started checking all Exceptions including nose SkipTest(), at #3963
and #3876 which are included in 3.2.0 and 4.0, and all unit tests that
skips is recognized as test failure. Additionally, this patch starts
supporting Chainer 3.2.0 and 2.1.0, dropping 1.x as well.