MultiNodeIterator #186
Merged
MultiNodeIterator #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shu65
requested changes
Feb 23, 2018
There was a problem hiding this comment.
How about adding tests to check the compatibility of the iterator.
https://github.com/chainer/chainer/blob/master/tests/chainer_tests/iterators_tests/test_iterator_compatibility.py
chainermn/communicators/_base.py
Outdated
|
|
||
| msgtype = self.mpi_comm.bcast(msgtype, root) | ||
| shape = msgtype.shapes[0] | ||
| buf = _memory_utility.array_to_buffer_object(x) |
There was a problem hiding this comment.
Since the data type of x assumes float32, I think that it is better to add an assertion to check x.dtype.
chainermn/communicators/_base.py
Outdated
| 'gather cannot handle different shapes of data') | ||
|
|
||
| # Gather data. | ||
| sbuf = _memory_utility.array_to_buffer_object(x) |
shu65
requested changes
Mar 2, 2018
chainermn/communicators/_base.py
Outdated
| if is_master: | ||
| msgtype = _MessageType(x) | ||
| if msgtype.is_tuple: | ||
| raise ValueError('cannot broadcast tuple data') |
shu65
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
MultiNodeIterator, where master process broadcasts shuffled batches to slave processes.In addition to
MultiNodeIterator, this PR also adds the following features, needed for implementing it:bcastandgatherfor ChainerMN communicatorchainermn.functions.bcast-> not needed anymore