Add allreduce method to communicator interface with implementation #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuenishi
force-pushed
the
allreduce-ndarray
branch
from
5e40aff
to
d5db92e
Compare
shu65
approved these changes
Apr 20, 2018
| xs = x.astype(np.float32) | ||
| xs = self.communicator.allreduce(xs) | ||
|
|
||
| sum = reduce(lambda a, b: a + b, |
There was a problem hiding this comment.
Why do you use reduce instead of sum?
There was a problem hiding this comment.
I just didn't know that and updated.
kuenishi
force-pushed
the
allreduce-ndarray
branch
from
8f6f7c0
to
e105e43
Compare
kuenishi
force-pushed
the
allreduce-ndarray
branch
2 times, most recently
from
19d076e
to
6b15ce5
Compare
kuenishi
force-pushed
the
allreduce-ndarray
branch
from
6b15ce5
to
8fe6755
Compare
This was referenced May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #235 and addresses #234 .