Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assert for cases when use_nccl == False #68

Merged
merged 2 commits into from May 25, 2017
Merged

Fix assert for cases when use_nccl == False #68

merged 2 commits into from May 25, 2017

Conversation

iwiwi
Copy link
Contributor

@iwiwi iwiwi commented May 25, 2017 •
edited

This PR fixes the issue that FlatCommunicator fails when allreduce_grad is called more than once.

@iwiwi iwiwi changed the title Fix assert for cases when use_nccl == False [WIP] Fix assert for cases when use_nccl == False May 25, 2017
@iwiwi iwiwi changed the title [WIP] Fix assert for cases when use_nccl == False Fix assert for cases when use_nccl == False May 25, 2017
@keisukefukuda keisukefukuda merged commit 78dee8c into master May 25, 2017
@keisukefukuda keisukefukuda deleted the iwiwi-patch-1 branch May 25, 2017 11:16
@iwiwi iwiwi added this to the v1.0.0b2 milestone May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug installation
Projects
None yet
Milestone
v1.0.0b2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iwiwi @keisukefukuda