Use Chainer v2 #100
Merged
Use Chainer v2 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainer PR #2764
|
Changes Unknown when pulling a855613 on toslunar:chainerv2 into ** on pfnet:master**. |
|
Changes Unknown when pulling f7e6a99 on toslunar:chainerv2 into ** on pfnet:master**. |
|
Changes Unknown when pulling 04ede2d on toslunar:chainerv2 into ** on pfnet:master**. |
muupan
reviewed
Jun 2, 2017
chainerrl/agent.py
Outdated
| @@ -107,7 +119,7 @@ def save(self, dirname): | |||
| def load(self, dirname): | |||
| """Load internal states.""" | |||
| for attr in self.saved_attributes: | |||
| serializers.load_npz( | |||
| load_npz_no_strict( | |||
There was a problem hiding this comment.
What is the reason behind this change? It's better to add comments if this is a fix for some problem.
muupan
reviewed
Jun 2, 2017
chainerrl/agents/a3c.py
Outdated
| @@ -226,7 +226,9 @@ def update(self, statevar): | |||
| target_link=self.shared_model, source_link=self.model) | |||
| # Update the globally shared model | |||
| if self.process_idx == 0: | |||
| norm = self.optimizer.compute_grads_norm() | |||
| # norm = self.optimizer.compute_grads_norm() | |||
muupan
reviewed
Jun 2, 2017
chainerrl/agents/acer.py
Outdated
| @@ -523,7 +523,9 @@ def update(self, t_start, t_stop, R, states, actions, rewards, values, | |||
| target_link=self.shared_model, source_link=self.model) | |||
| # Update the globally shared model | |||
| if self.process_idx == 0: | |||
| norm = self.optimizer.compute_grads_norm() | |||
| # norm = self.optimizer.compute_grads_norm() | |||
muupan
reviewed
Jun 2, 2017
chainerrl/agents/pcl.py
Outdated
| @@ -248,7 +248,10 @@ def update(self, loss): | |||
| copy_param.copy_grad( | |||
| target_link=self.shared_model, source_link=self.model) | |||
| if self.process_idx == 0: | |||
| norm = self.optimizer.compute_grads_norm() | |||
| # norm = self.optimizer.compute_grads_norm() | |||
muupan
reviewed
Jun 2, 2017
chainerrl/agents/pcl.py
Outdated
| @@ -137,7 +137,7 @@ def __init__(self, model, optimizer, | |||
| self.pi_loss_coef = pi_loss_coef | |||
| self.v_loss_coef = v_loss_coef | |||
| self.rollout_len = rollout_len | |||
| self.batchsize = batchsize | |||
| self.batchsize = self.xp.int32(batchsize) | |||
There was a problem hiding this comment.
I guess this is a fix for newint, but it's not clear from the code. Can you add a comment?
muupan
reviewed
Jun 2, 2017
chainerrl/initializers/normal.py
Outdated
| class LeCunNormal(chainer.initializers.HeNormal): | ||
| """sorry | ||
|
|
||
| """ |
muupan
reviewed
Jun 2, 2017
chainerrl/misc/async.py
Outdated
| def ensure_initialized_update_rule(param): | ||
| u = param.update_rule | ||
| if u.state is None: | ||
| u._state = {} # Sorry! |
muupan
reviewed
Jun 2, 2017
.travis.yml
Outdated
| - cd chainer | ||
| - git checkout _v2 | ||
| - python setup.py install | ||
| - cd .. |
There was a problem hiding this comment.
Now that chainer v2 is released, can you undo these changes?
muupan
reviewed
Jun 2, 2017
tests/misc_tests/test_async.py
Outdated
| @@ -67,42 +68,56 @@ def test_share_states(self): | |||
| opt_a.setup(model) | |||
| arrays = async.share_states_as_shared_arrays(opt_a) | |||
| opt_b = optimizers.RMSprop() | |||
| opt_b.setup(model) | |||
| opt_b.setup(copy.deepcopy(model)) | |||
| opt_b.update() # sorry | |||
muupan
reviewed
Jun 2, 2017
tests/misc_tests/test_async.py
Outdated
| @@ -67,42 +68,56 @@ def test_share_states(self): | |||
| opt_a.setup(model) | |||
| arrays = async.share_states_as_shared_arrays(opt_a) | |||
| opt_b = optimizers.RMSprop() | |||
| opt_b.setup(model) | |||
| opt_b.setup(copy.deepcopy(model)) | |||
There was a problem hiding this comment.
Why is copy.deepcopy required here?
|
Great work! Have you checked tests (including gpu and slow tests) in your environment? |
This reverts commit 07c9d3c.
|
Some slow tests fail because of BLAS errors that seem to be chainer/chainer#2744. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.