Add PPO agent #126
Merged
Add PPO agent #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling aa30724 on toslunar:ppo-agent into ** on chainer:master**. |
|
Changes Unknown when pulling 7bf31c1 on toslunar:ppo-agent into ** on chainer:master**. |
|
Changes Unknown when pulling 7197d63 on toslunar:ppo-agent into ** on chainer:master**. |
|
Changes Unknown when pulling 7da765b on toslunar:ppo-agent into ** on chainer:master**. |
|
How is the performance? |
|
passed the GPU tests
on the commit f31626c, in Python 3. |
muupan
reviewed
Nov 9, 2017
| shape (int or tuple of int): Shape of input values except batch axis. | ||
| batch_axis (int): Batch axis. | ||
| eps (float): Small value for stability. | ||
| dtype (dtype): Dtype of input values. |
muupan
requested changes
Nov 9, 2017
| # clear cache | ||
| self._cached_std_inverse = None | ||
|
|
||
| def __call__(self, x, update=True): |
There was a problem hiding this comment.
Can you add a docstring, since update is important?
|
|
||
| return self._cached_std_inverse | ||
|
|
||
| def experience(self, x): |
| layers.append(L.Linear(n_input_channels, n_hidden_channels)) | ||
| for _ in range(n_hidden_layers - 1): | ||
| layers.append(self.nonlinearity) | ||
| layers.append(L.Linear(n_hidden_channels, n_hidden_channels)) |
There was a problem hiding this comment.
Nonlinearity is missing before the last layer
muupan
approved these changes
Nov 13, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #120.
Currently, this only supports environments with discrete actions