Use F.matmul instead of F.batch_matmul #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, the PR depends on the new F.matmul in v3. |
|
I think It is better to support both v2 and v3 for now by checking the version of chainer and use F.numpy_like_matmul for v2. |
|
Can you merge the current master to this PR so that CI runs with both Chainer v2 and v3? |
muupan
reviewed
Oct 17, 2017
chainerrl/misc/chainer_compat.py
Outdated
| pkg_resources.get_distribution("chainer").version) | ||
|
|
||
| if chainer_version < StrictVersion('3.0.0a1'): | ||
| def matmul_v3(a, b, **kwargs): |
There was a problem hiding this comment.
Can you add a docstring to explain why this is needed?
|
Rebased to the current master |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batch_matmul is going to be unavailable in Chainer v3, or would be deprecated even if chainer/chainer#3016 is merged.