Split test_examples.sh #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toslunar
reviewed
Jun 12, 2019
| python examples/mujoco/td3/train_td3.py --env Pendulum-v0 --gpu $gpu --steps 10 --replay-start-size 5 --batch-size 5 --outdir $outdir/mujoco/td3 | ||
| model=$(find $outdir/mujoco/td3 -name "*_finish") | ||
| python examples/mujoco/td3/train_td3.py --env Pendulum-v0 --demo --load $model --eval-n-runs 1 --outdir $outdir/temp --gpu $gpu | ||
| for SCRIPT in $(find examples_tests/ -type f -name '*.sh') |
There was a problem hiding this comment.
Suggested change
| for SCRIPT in $(find examples_tests/ -type f -name '*.sh') | |
| for SCRIPT in $(find examples_tests/ -type f -name 'test_*.sh') |
if non-test scripts will be added under the directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
test_examples.shto multiple files so that each example script has a corresponding test script. This change allows executing tests for a single example script separately and avoiding unnecessary conflicts due to modifyingtest_examples.shat the same time.