Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loop_select conditions (PRO-587) #4061

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Conversation

AlastairHolmes
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Sep 28, 2023

PRO-587 Review loop_select exit conditions

See TODO comments

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #4061 (4d1bfad) into main (0168147) will decrease coverage by 0%.
Report is 5 commits behind head on main.
The diff coverage is 82%.

@@          Coverage Diff           @@
##            main   #4061    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        376     376            
  Lines      59433   59662   +229     
  Branches   59433   59662   +229     
======================================
+ Hits       42506   42547    +41     
- Misses     14816   14965   +149     
- Partials    2111    2150    +39     
Files Coverage Δ
engine/src/witness/common/chain_source/shared.rs 0% <0%> (ø)
...chain_source/chunked_by_vault/deposit_addresses.rs 0% <0%> (ø)
...nked_chain_source/chunked_by_vault/egress_items.rs 0% <0%> (ø)
utilities/src/with_std/loop_select.rs 71% <90%> (-1%) ⬇️

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlastairHolmes AlastairHolmes enabled auto-merge (squash) September 29, 2023 14:36
@AlastairHolmes AlastairHolmes merged commit 8a2d95a into main Sep 29, 2023
43 of 44 checks passed
@AlastairHolmes AlastairHolmes deleted the fix/loop_select-conditions branch September 29, 2023 15:00
syan095 added a commit that referenced this pull request Oct 2, 2023
…tbeat

* origin/main:
  fix: loop_select conditions (PRO-587) (#4061)
  chore: remove unused config items (#4064)
  feat: size limit for CCM (#4015)
  fix: warn -> info (#4060)
syan095 added a commit that referenced this pull request Oct 3, 2023
* origin/main:
  Feat: don't include dust btc amounts on rotation (#4063)
  chore: update dependency and config.toml for RUSTSEC-2023-0065 (#4066)
  fix: loop_select conditions (PRO-587) (#4061)
  chore: remove unused config items (#4064)
  feat: size limit for CCM (#4015)
  fix: warn -> info (#4060)
  Fix: correctly handle peer updates while waiting to reconnect (#4052)

# Conflicts:
#	state-chain/chains/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants