adapt banana mode to new LP-API methods and events #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4181 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 380 379 -1
Lines 61591 61572 -19
Branches 61591 61572 -19
=====================================
+ Hits 44174 44175 +1
+ Misses 15119 15096 -23
- Partials 2298 2301 +3 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msgmaxim
approved these changes
Oct 30, 2023
j4m1ef0rd
reviewed
Oct 31, 2023
| @@ -20,7 +22,7 @@ import { provideLiquidity } from '../shared/provide_liquidity'; | |||
| async function call(method: string, params: any, id: string) { | |||
There was a problem hiding this comment.
I think we have some duplicate functionality here. I created a similar function in shared/json_rpc.ts that uses fetch instead of axios. No idea which one is better. Maybe we can de-duplicate this during PRO-919.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related to and blocked by PR #4176
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
This updates banana mode to support the new LP-API method names and returned data.