Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing spans in multisig logs #4239

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: add missing spans in multisig logs #4239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions engine/multisig/src/client/ceremony_runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,7 @@ where
if let Some(start_instant) = ceremony_start {
let duration = start_instant.elapsed().as_millis();
runner.metrics.ceremony_duration.set(duration);
tracing::info!(
"Ceremony {} ({}) took {}ms to complete",
Ceremony::CEREMONY_TYPE,
ceremony_id,
duration
);
span.in_scope(|| tracing::info!("Ceremony took {}ms to complete", duration));
}
let _result = runner.outcome_sender.send((ceremony_id, outcome));
Ok(())
Expand Down Expand Up @@ -222,7 +217,8 @@ where
}

/// Process message from a peer, returning ceremony outcome if
/// the ceremony stage machine cannot progress any further
/// the ceremony stage machine cannot progress any further.
/// Note: this is only public because of tests.
pub async fn process_or_delay_message(
&mut self,
sender_id: AccountId,
Expand Down
1 change: 1 addition & 0 deletions engine/multisig/src/client/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ impl<C: ChainSigning, KeyStore: KeyStoreAPI<C>> MultisigClientApi<C::CryptoSchem
(reported_parties, failure_reason)
})
}
.instrument(span.clone())
.boxed()
} else {
// No key was found for the given key_id
Expand Down