fix: ignore extra btc vouts #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlastairHolmes
approved these changes
Nov 30, 2023
AlastairHolmes
approved these changes
Nov 30, 2023
| for (vout, tx_out) in (0..).zip(&tx.output) { | ||
| if tx_out.value > 0 { | ||
|
|
||
| if let Some(deposit) = (0..) |
There was a problem hiding this comment.
A valid usecase would be this: You want to swap your bitcoin into DOT and ETH. You generate two deposit channels, and send funds to both in a single transaction. We should allow this, but it wouldn't work with the suggested change. We should only filter out outputs in the same TX to the same destination address
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1007
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Ignores extra BTC vouts in a single transaction.