Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swap): handle network fee correctly [WEB-1028] #772

Merged
merged 4 commits into from
May 31, 2024

Conversation

acdibble
Copy link
Collaborator

No description provided.

@acdibble acdibble requested a review from a team as a code owner May 30, 2024 14:02
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (c0ca3b5) to head (20cac3c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   86.89%   86.87%   -0.03%     
==========================================
  Files         101      101              
  Lines        1435     1432       -3     
  Branches      213      213              
==========================================
- Hits         1247     1244       -3     
  Misses        179      179              
  Partials        9        9              
Flag Coverage Δ
sdk 95.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acdibble acdibble changed the title fix(swap): handle network fee correctly fix(swap): handle network fee correctly [WEB-1028] May 31, 2024
@acdibble acdibble merged commit d999279 into main May 31, 2024
20 checks passed
@acdibble acdibble deleted the fix/network-fee-calculation branch May 31, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants