Add profiling to help with OOM/performance investigations #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egibs
changed the title
tstromberg
requested changes
May 10, 2024
bincapz.go
Outdated
| @@ -9,13 +9,15 @@ import ( | |||
| "flag" | |||
| "fmt" | |||
| "io/fs" | |||
| "log" | |||
There was a problem hiding this comment.
Rather than adding a second logging library, please re-use the clog import - even if, admittedly, I prefer the built-in Go library.
There was a problem hiding this comment.
Addressed in c978170 (#207).
pkg/profile/profile.go
Outdated
| return stop, nil | ||
| } | ||
|
|
||
| func HandleProfileFlag(pf *bool) error { |
There was a problem hiding this comment.
Please move all flag handling to main.
There was a problem hiding this comment.
Addressed in c978170 (#207).
egibs
commented
May 10, 2024
| log.Fatal("render failed", slog.Any("error", err)) | ||
| } | ||
|
|
||
| if *profileFlag { |
There was a problem hiding this comment.
This avoids os.Exit(1) and defer not playing nicely together.
egibs
pushed a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
…-dev#207) * Add profiling to help with OOM/performance * Profile doesn't need to be exported * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick PR to help with identifying the cause(s) of #204 which adds CPU and Memory profiling along with tracing.
If anything, I wanted the code to be available to aid with the investigation -- this doesn't necessarily need to be merged; however, as the number of capabilities grows it would be nice to have some insight into any causes of performance regressions.