-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version support #210
Merged
Merged
Add version support #210
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
db7ab4b
Add version support
e6d6c07
Appease the linter
64d7b77
Merge branch 'main' into add-version
de1809a
make fix
43ea7a0
Merge branch 'main' into add-version
6cf0951
Merge branch 'main' into add-version
90c2792
Merge branch 'main' into add-version
9aa607c
Match GoReleaser config
c248ddc
Store version in version package
e7a663e
Merge branch 'main' into add-version
5be38e1
Remove VERSION file
2bdc5bc
Fix indentation
9b582f9
Capitalize flag usage
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
package version | ||
|
||
import ( | ||
"fmt" | ||
"runtime/debug" | ||
) | ||
|
||
const ( | ||
ID string = "0.11.0" | ||
) | ||
|
||
// Check if the build info contains a version. | ||
func getBinaryVersion() (string, error) { | ||
buildInfo, ok := debug.ReadBuildInfo() | ||
if !ok { | ||
return "", fmt.Errorf("failed to read build info") | ||
} | ||
|
||
for _, setting := range buildInfo.Settings { | ||
if setting.Key == "main.BuildVersion" { | ||
return setting.Value, nil | ||
} | ||
} | ||
|
||
return "", nil | ||
} | ||
|
||
func Version() (string, error) { | ||
var v string | ||
var err error | ||
// Check for the version in the binary first | ||
if v, err = getBinaryVersion(); err != nil { | ||
return "bincapz unknown version", err | ||
} | ||
// If present, return that value | ||
// Otherwise, fall back to the contents of the VERSION const | ||
if v != "" { | ||
return fmt.Sprintf("bincapz %s", v), nil | ||
} | ||
return fmt.Sprintf("bincapz %s", ID), nil | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize "Show" for consistency with your more recent flag changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
9b582f9
(#210).