Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter-prefix option to update config. #1083

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add filter-prefix option to update config. #1083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,8 @@ type Update struct {
GitHubMonitor *GitHubMonitor `json:"github,omitempty" yaml:"github,omitempty"`
// The configuration block for transforming the `package.version` into an APK version
VersionTransform []VersionTransform `json:"version-transform,omitempty" yaml:"version-transform,omitempty"`
// Prefix filter to apply when searching releases
FilterPrefix string `json:"filter-prefix,omitempty" yaml:"filter-prefix,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if putting it under the update block will cause confusion with the existing filter-prefix that is under the github block? I.e. would it be better if we move this under the release-monitor block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe Deprecate the 'TagFilterPrefix' in github block? filtering strings isn't really "provider specific".

I'm happy to do whatever you think is right.

}

// ReleaseMonitor indicates using the API for https://release-monitoring.org/
Expand Down
4 changes: 4 additions & 0 deletions pkg/config/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,10 @@
},
"type": "array",
"description": "The configuration block for transforming the `package.version` into an APK version"
},
"filter-prefix": {
"type": "string",
"description": "Prefix filter to apply when searching releases"
}
},
"additionalProperties": false,
Expand Down