Use current user's ID when building via Docker #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
|
thanks for the contribution 🙏 ! would you mind resolving the conflicts and I'll kick off CI? |
Signed-off-by: Evan Gibler <20933572+egibs@users.noreply.github.com>
Done! |
|
Kicked off CI! @egibs cc/ @joshrwolf |
jonjohnsonjr
approved these changes
Jun 21, 2024
smoser
added a commit
to smoser/wolfictl
that referenced
this pull request
Jun 26, 2024
Notable: * Use current user's ID when building via Docker chainguard-dev/melange#1298 * Make running the git-checkout via melange not emit WARN messages. * feat - add flag to go/build to run go mod tidy chainguard-dev/melange#1303 * enforce some more lint checks * Add git-cherry-pick pipeline chainguard-dev/melange#1278 Signed-off-by: Scott Moser <smoser@brickies.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Melange Pull Request Template
Relates to: #1255
This PR introduces parity between Bubblewrap and Docker, that is, builds will default to the current UID with Docker but can still be configured via
cfg.RunAs.Functional Changes
Notes:
SCA Changes
Notes:
Linter
Notes:
Works as expected -- on my Mac this defaulted to a UID of
501rather than an empty string (which translates to0).I tested this via these commands:
and then used
[]string{"id", "-u"}for the containerCmdto check the UID.Original code:
New code: