Add alert on dlq messages #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
mattmoor
reviewed
Feb 26, 2024
mattmoor
reviewed
Feb 26, 2024
Comment on lines
10
to
22
| condition_threshold { | ||
| aggregations { | ||
| alignment_period = "300s" | ||
| per_series_aligner = "ALIGN_MEAN" | ||
| } | ||
|
|
||
| comparison = "COMPARISON_GT" | ||
| duration = "0s" | ||
| filter = "metric.type=\"pubsub.googleapis.com/topic/send_request_count\" resource.type=\"pubsub_topic\" metadata.system_labels.\"name\"=\"${google_pubsub_topic.dead-letter.name}\"" | ||
|
|
||
| trigger { | ||
| count = "1" | ||
| } |
There was a problem hiding this comment.
@k4leung4 what's the right aligner / period here for this metric type?
There was a problem hiding this comment.
mean or max or work here
https://cloud.google.com/monitoring/api/v3/aggregation#aligners
There was a problem hiding this comment.
no change needed then?
mattmoor
reviewed
Feb 26, 2024
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
k4leung4
approved these changes
Feb 26, 2024
jdolitsky
commented
Feb 26, 2024
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
k4leung4
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.