Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate static image #38

Merged
merged 5 commits into from
Nov 18, 2022
Merged

migrate static image #38

merged 5 commits into from
Nov 18, 2022

Conversation

kaniini
Copy link
Contributor

@kaniini kaniini commented Nov 18, 2022

No description provided.

jdolitsky
jdolitsky requested changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. needs rebase (we need to fix build action to be ok w/ this)
  2. I think we can drop images/static/.github/

@kaniini kaniini force-pushed the feature/migrate-static branch 2 times, most recently from 197d045 to e1d9456 Compare November 18, 2022 21:02
jdolitsky
jdolitsky requested changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test.sh needs to change dir to the directory it is in (since it is being run from repo root)

Maybe something like:

cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

before "docker build"

@jdolitsky
Copy link
Contributor

we could also fix this in the CI since #35 is failing for same reason

@kaniini
Copy link
Contributor Author

kaniini commented Nov 18, 2022

Better to fix in the CI imho.

@jdolitsky
Copy link
Contributor

@kaniini - sounds good. ill put that in now

@kaniini
Copy link
Contributor Author

kaniini commented Nov 18, 2022

Sounds good, I'll rebase this PR afterward :D

@jdolitsky jdolitsky mentioned this pull request Nov 18, 2022
Merged
@kaniini
migrate static image
c7584f5 
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini
update README
a252228 
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini
static: switch to wolfi base
59b2526 
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini
kill .github directory
c7abe47 
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini
kill the README file too
85fa363 
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@jdolitsky jdolitsky merged commit caa24f9 into main Nov 18, 2022
@jdolitsky jdolitsky deleted the feature/migrate-static branch November 18, 2022 21:37
@jdolitsky jdolitsky mentioned this pull request Nov 18, 2022
Closed
22 tasks
jdolitsky added a commit that referenced this pull request Dec 1, 2022
@jdolitsky
Merge pull request #38 from chainguard-images/feature/migrate-static
b9c143f 
migrate static image
developer-guy pushed a commit to Dentrax/images that referenced this pull request Feb 12, 2024
@rawlingsj
Merge pull request chainguard-images#38 from rawlingsj/wolfictl
5d9dffe 
add linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaniini @jdolitsky