Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change maxSize limits for CAS Backend #618

Open
prog8 opened this issue Mar 14, 2024 · 1 comment
Open

Unable to change maxSize limits for CAS Backend #618

prog8 opened this issue Mar 14, 2024 · 1 comment
Assignees

Comments

@prog8
Copy link

prog8 commented Mar 14, 2024

I have artifact which is bigger than 100MB so material crafting fails because of too big file.

As far as I can see in https://github.com/chainloop-dev/chainloop/blob/main/app/controlplane/internal/data/casbackend.go#L223-L226 it's impossible to change the limit for max size for CAS backend. Are there plans to make this parameter configurable or maybe it is configurable and I'm looking at wrong part of the code?

Thanks in advance for all suggestions and hints.

@migmartri
Copy link
Member

migmartri commented Mar 14, 2024

Hi @prog8, thanks for reporting the issue.

You are correct, those values are currently hardcoded but changing that should be doable.

Basically we would need to keep these values as defaults but then make sure we

  • Store the limits in the cas-backends DB table since they will be configurable. This can be done in (internal/ent/schemas/casbackend.go)
  • Update the business logic (biz/casbackend.go) and the data logic (data/casbackend.go) to support the new parameter
  • Update the API to support receiving this value in both creation and update, cas_backends.proto
  • Lastly, you'll need to update the CLI to support providing the limit value during creation/update

Does it make sense? Is this something you'd like to work on? I am happy to help, you can find me here in Discord.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants