Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cas): download endpoint #294

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

migmartri
Copy link
Member

Exposes a new /download/{digest}?t={token} http endpoint that will

  • Stream the resulting file to the browser
  • Set the size and content-disposition headers

Peek 2023-08-02 02-20

Closes #293

@migmartri migmartri marked this pull request as ready for review August 2, 2023 07:13
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please take a look at my comments

app/artifact-cas/internal/server/grpc.go Outdated Show resolved Hide resolved
app/artifact-cas/internal/server/http.go Outdated Show resolved Hide resolved
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri merged commit 9853beb into chainloop-dev:main Aug 21, 2023
10 of 11 checks passed
@migmartri migmartri deleted the download-from-http branch August 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: http download endpoint for items in CAS
2 participants